Help, I desperately need help, I get wrong angles when setting microstepping

Turns out the script wasn’t working right due to integer overflows. I got some help on another forum and chatGPT.

I’m pasting the final script in case someone needs it.

This script allows you to build your own rotator and it features a meridian flip fix so there are no interruptions when a satellite is crossing North. I have not written the script myself, I got the original script from here: Solved the meridian flip problem

This is a modified script with bug fixes that allows you to use microstepping without buffer overflows which prevented the correct fuctions if you used higher than 400 steps per revolution. It is preset to use 1/8 microsteps as is.

#include <stdlib.h>
#include <math.h>
#include <AccelStepper.h>

#define DIR_AZ 9 //PIN for Azimuth Direction
#define STEP_AZ 10 //PIN for Azimuth Steps
#define DIR_EL 6 //PIN for Elevation Direction
#define STEP_EL 7 //PIN for Elevation Steps

#define MS1 18 //PIN for step size
#define EN 8 //PIN for Enable or Disable Stepper Motors

#define SPR 1600L //Step Per Revolution
#define RATIO 50L //Gear ratio
#define T_DELAY 60000 //Time to disable the motors in millisecond

#define HOME_AZ 4 //Homing switch for Azimuth
#define HOME_EL 5 //Homing switch for Elevation
/*The MAX_ANGLE depends of ANGLE_SCANNING_MULT and maybe misbehave for large values*/
#define ANGLE_SCANNING_MULT 180 //Angle scanning multiplier
#define MAX_AZ_ANGLE 360 //Maximum Angle of Azimuth for homing scanning
#define MAX_EL_ANGLE 360 //Maximum Angle of Elevation for homing scanning

#define HOME_DELAY 6000 //Time for homing Decceleration in millisecond

/*Global Variables*/
unsigned long t_DIS = 0; //time to disable the Motors
/*Define a stepper and the pins it will use*/
AccelStepper AZstepper(1, STEP_AZ, DIR_AZ);
AccelStepper ELstepper(1, STEP_EL, DIR_EL);

void setup()
{  
  /*Change these to suit your stepper if you want*/
  AZstepper.setMaxSpeed(1600);
  AZstepper.setAcceleration(1000);
  
  /*Change these to suit your stepper if you want*/
  ELstepper.setMaxSpeed(1600);
  ELstepper.setAcceleration(1000);
  
  /*Enable Motors*/
  pinMode(EN, OUTPUT);
  digitalWrite(EN, LOW);
  /*Step size*/
  pinMode(MS1, OUTPUT);
  digitalWrite(MS1, HIGH); //Full step
  /*Homing switch*/
  pinMode(HOME_AZ, INPUT);
  pinMode(HOME_EL, INPUT);
  /*Serial1 Communication*/
  Serial.begin(19200);
  Serial1.begin(19200); // Use Serial1 for RX/TX on Arduino Nano, othewise change Serial1 to Serial
  /*Initial Homing*/
  Homing(deg2step(-ANGLE_SCANNING_MULT), deg2step(-ANGLE_SCANNING_MULT));
}

void loop()
{ 
  /*Define the steps*/
  static long AZstep = 0;
  static long ELstep = 0;
  /*Time Check*/
  if (t_DIS == 0)
    t_DIS = millis();

  /*Disable Motors*/
  if (AZstep == AZstepper.currentPosition() && ELstep == ELstepper.currentPosition() && millis()-t_DIS > T_DELAY)
  {
    digitalWrite(EN, HIGH);
  }
  /*Enable Motors*/
  else
    digitalWrite(EN, LOW);
    
  /*Read the steps from Serial1*/
  cmd_proc(AZstep, ELstep);
  /*Move the Azimuth & Elevation Motor*/
  stepper_move(AZstep, ELstep);
}

/*Homing Function*/
void Homing(long AZsteps, long ELsteps)
{
  long value_Home_AZ = HIGH;
  long value_Home_EL = HIGH;
  long n_AZ = 1; //Times that AZ angle has changed
  long n_EL = 1; //Times that EL angle has changed
  boolean isHome_AZ = false;
  boolean isHome_EL = false;
  
  AZstepper.moveTo(AZsteps);
  ELstepper.moveTo(ELsteps);
  
  while(isHome_AZ == false || isHome_EL == false)
  {
    value_Home_AZ = digitalRead(HOME_AZ);
    value_Home_EL = digitalRead(HOME_EL);
    /* Change to LOW according to Home sensor */
    if (value_Home_AZ == HIGH)
    {
      AZstepper.moveTo(AZstepper.currentPosition());
      isHome_AZ = true;
    }   
    /* Change to LOW according to Home sensor */
    if (value_Home_EL == HIGH)
    {
      ELstepper.moveTo(ELstepper.currentPosition());
      isHome_EL = true;
    }
    if (AZstepper.distanceToGo() == 0 && !isHome_AZ)
    {
      n_AZ++;
      AZsteps = deg2step(pow(-1,n_AZ)*n_AZ*ANGLE_SCANNING_MULT);
      if (abs(n_AZ*ANGLE_SCANNING_MULT) > MAX_AZ_ANGLE)
      {
        error(0);
        break;
      }
      AZstepper.moveTo(AZsteps);
    } 
    if (ELstepper.distanceToGo() == 0 && !isHome_EL)
    { 
      n_EL++;
      ELsteps = deg2step(pow(-1,n_EL)*n_EL*ANGLE_SCANNING_MULT);
      if (abs(n_EL*ANGLE_SCANNING_MULT) > MAX_EL_ANGLE)
      {
        error(1);
        break;
      }
      ELstepper.moveTo(ELsteps);
    }
    
    AZstepper.run();
    ELstepper.run();
  }
  /*Delay to Deccelerate*/
  long time = millis();  
  while(millis() - time < HOME_DELAY)
  {  
    AZstepper.run();
    ELstepper.run();
  }
  /*Reset the steps*/
  AZstepper.setCurrentPosition(0);
  ELstepper.setCurrentPosition(0); 
}
 
/*EasyComm 2 Protocol & Calculate the steps*/
void cmd_proc(long &stepAz, long &stepEl)
{
  /*Serial1*/
  char buffer[256];
  char incomingByte;
  char *p=buffer;
  char *str;
  static long counter=0;
  char data[100];
  
  double angleAz,angleEl;
  
  /*Read from Serial1*/
  while (Serial1.available() > 0)
  {
    incomingByte = Serial1.read();
    /* XXX: Get position using custom and test code */
    if (incomingByte == '!')
    {
      /* Get position */
      Serial1.print("TM");
      Serial1.print(1);
      Serial1.print(" ");
      Serial1.print("AZ");
      Serial1.print(10*step2deg(AZstepper.currentPosition()), 1);
      Serial1.print(" ");
      Serial1.print("EL");
      Serial1.println(10*step2deg(ELstepper.currentPosition()), 1);
    }
    /*new data*/
    else if (incomingByte == '\n')
    {
      p = buffer;
      buffer[counter] = 0;
      if (buffer[0] == 'A' && buffer[1] == 'Z')
      {
        if (buffer[2] == ' ' && buffer[3] == 'E' && buffer[4] == 'L')
        {
          /* Get position */
          Serial1.print("AZ");
          Serial1.print(step2deg(AZstepper.currentPosition()), 1);
          Serial1.print(" ");
          Serial1.print("EL");
          Serial1.print(step2deg(ELstepper.currentPosition()), 1);
          Serial1.println(" ");
        }
        else
        {
          /*Get the absolute value of angle*/
          str = strtok_r(p, " " , &p);
          strncpy(data, str+2, 10);
          angleAz = atof(data);
          /*Calculate the steps*/
          stepAz = deg2step(angleAz);
      
      //----------------------------------------------------------
      // detect any 360-0 or 0-360 crossing to avoid Meridian Flip
      //----------------------------------------------------------
          double eps;     // difference in degrees between positions, desired and current
      double az_val = angleAz;    // desired position in degrees
      double az_att = step2deg(AZstepper.currentPosition());  // current position in degrees
      
      // from here it is assumed that the positions are always between 0 and 360, so to be safe it returns them to the range 0-360
      long n_giri=( long ) (az_att / 360.0);   // example: with az_att=357 -> ngiri = 0
        az_att = az_att - ((double) n_giri)*360.;  // current azimuth, reported between 0 and 360 degrees
      
      n_giri=( long ) (az_val / 360.0);
      az_val = az_val - ((double) n_giri)*360.;  // desired azimuth, reported between 0 and 360 degrees
      
          eps = az_val - az_att;     // calculate position error
  
          if (fabs(eps) > 180.)      // must make more than a half turn (so it must cross north)
          {
             if (az_att < 180)       // go through it turning counterclockwise
             {
               // example: it must go from +10 to +350, eps becomes (350-360)-10=-20 and turns backwards
               eps = (az_val - 360) - az_att; 
             }
             else    // az_att > 180
             {
               // passed north by turning clockwise (example az_att=350 and az_val=10)
               eps = az_val -(az_att - 360);   // 10 - (350 - 360) = +20 e and continues clockwise
             }      // end if az_att > 180
          }   // end if fabs(eps) > 180

          // redefines the desired position in steps
          stepAz = AZstepper.currentPosition() + deg2step(eps);   
      //------------------------------------------------------
      // end of meridian flip detection code
      //------------------------------------------------------

          /*Get the absolute value of angle*/
          str = strtok_r(p, " " , &p);
          if (str[0] == 'E' && str[1] == 'L')
          {
            strncpy(data, str+2, 10);
            angleEl = atof(data);
            /*Calculate the steps*/
            stepEl = deg2step(angleEl);
          }
        }
      }
      /* Stop Moving */
      else if (buffer[0] == 'S' && buffer[1] == 'A' && buffer[2] == ' ' && buffer[3] == 'S' && buffer[4] == 'E')
      {
        /* Get position */
        Serial1.print("AZ");
        Serial1.print(step2deg(AZstepper.currentPosition()), 1);
        Serial1.print(" ");
        Serial1.print("EL");
        Serial1.println(step2deg(ELstepper.currentPosition()), 1);
        stepAz = AZstepper.currentPosition();
        stepEl = ELstepper.currentPosition();
      }
      /* Reset the rotator */
      else if (buffer[0] == 'R' && buffer[1] == 'E' && buffer[2] == 'S' && buffer[3] == 'E' && buffer[4] == 'T')
      {
        /* Get position */
        Serial1.print("AZ");
        Serial1.print(step2deg(AZstepper.currentPosition()), 1);
        Serial1.print(" ");
        Serial1.print("EL");
        Serial1.println(step2deg(ELstepper.currentPosition()), 1);
        /*Move the steppers to initial position*/
        Homing(0,0);
        /*Zero the steps*/
        stepAz = 0;
        stepEl = 0;
      }      
      counter = 0;
      /*Reset the disable motor time*/
      t_DIS = 0;
    }
    /*Fill the buffer with incoming data*/
    else {
      buffer[counter] = incomingByte;
      counter++;
    }
  }
}

/*Error Handling*/
void error(long num_error)
{
  switch (num_error)
  {
    /*Azimuth error*/
    case (0):
      while(1)
      {
        Serial1.println("AL001");
        delay(100);
      }
    /*Elevation error*/
    case (1):
      while(1)
      {
        Serial1.println("AL002");
        delay(100);
      }
    default:
      while(1)
      {
        Serial1.println("AL000");
        delay(100);
      }
  }
}

/*Send pulses to stepper motor drivers*/
void stepper_move(long stepAz, long stepEl)
{
  AZstepper.moveTo(stepAz);
  ELstepper.moveTo(stepEl);
    
  AZstepper.run();
  ELstepper.run();
}

// Convert degrees to steps
/* original code out-commented
long deg2step(double deg)
{
  return(RATIO*SPR*deg/360);
}
*/

//Convert degrees to steps
long deg2step(double deg)
{
  return(RATIO*SPR*deg/360);
}


/*Convert steps to degrees*/
double step2deg(long Step)
{
  return(360.00*Step/(SPR*RATIO));
}
3 Likes